Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dialog/complete doc #83

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix/dialog/complete doc #83

merged 2 commits into from
Jan 6, 2022

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Jan 6, 2022 •
edited
Loading

Button:

  • 将尺寸相关类名改回 BEM的方式
  • 完善属性，支持 content

Dialog：

  • 完善文档
  • 支持 cancelBtn 和 confirmBtn 透传属性至 t-button

close #82
close #61

@LeeJim LeeJim requested a review from jin0209 January 6, 2022 09:40
@JJunYang JJunYang merged commit 8c380ef into develop Jan 6, 2022
@JJunYang JJunYang deleted the fix/dialog/complete-doc branch January 6, 2022 11:04
jin0209
jin0209 reviewed Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@jin0209 jin0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin0209 jin0209 jin0209 left review comments

@JJunYang JJunYang JJunYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

官方h5演示 Dialog UI错位/无取消按钮 【Dialog】【Button】相关的问题
3 participants
@LeeJim @jin0209 @JJunYang